On Thu, May 18, 2017 at 09:55:41AM -0600, Simon Glass wrote:
Hi Tom,
On 17 May 2017 at 15:33, Tom Rini trini@konsulko.com wrote:
On Wed, May 17, 2017 at 08:23:09AM -0600, Simon Glass wrote:
We should not have an arch-specific header file in common.h. Instead, use the asm/hardware.h header to provide the required declarations, and drop the common.h changes.
Signed-off-by: Simon Glass sjg@chromium.org
I'm not a super fan of adding #include to config.h files, but I'll see if they can be dropped when testing the series.
Reviewed-by: Tom Rini trini@konsulko.com
Me neither. The problem is things like CONFIG_SYS_LOAD_ADDR in common/image.c which rely on things in asm/hardware. I suppose you could include it from asm/u-boot.h, but I'm not sure if that is better or not.
No, I need to bite the bullet and go back and re-try migration of CONFIG_SYS_TEXT_BASE (fully), CONFIG_SYS_LOAD_ADDR, etc.