Hi Jaehoon. The only degradation is that the check will be for every block in the deleted range and not for the range. I can move the check to mmc_erase_t, but then if the device is not supporting secure erase the error message will be printed for every block. I can check the support also in mmc_berase and print an error message only in this function. What do you think?
בתאריך יום ב׳, 28 בדצמ׳ 2020 ב-0:39 מאת Jaehoon Chung < jh80.chung@samsung.com>:
Hi Dennis,
On 12/26/20 5:44 PM, dennis laplacian1 wrote:
Hi Jaehoon Chung, for your comment: "ditto. if (IS_ENABLED()) instead of #if. And i don't know why doesn't check this in mmc_erase_t(). Then it doesn't need to pass arg as argument."
I check the support of secure erase in the mmc_berase and not in mmc_erase_t because mmc_erase_t is called multiple times for each block. So to prevent unnecessary checks, I check the support in mmc_berase function.
It there any problem to check a condition in mmc_erase_t()? or any dramatic degradation? And CONFIG_MMC_SECURE_ERASE is not enabled by default. So It doesn't need to add a variable.
Best Regards, Jaehoon Chung