In message fa686aa40709110814m5024c66bo536ff12d0b8be7cd@mail.gmail.com you wrote:
On 8/30/07, Michal Simek Monstr@seznam.cz wrote:
DESC: ROMFS support files and sorted names in Makefiles
Signed-off-by: Michal Simek monstr@monstr.eu
Note; I think that we can start process with redesigning all FS support
I'm still not really fond of this approach. Repurposing CONFIG_JFFS2 to add more and more filesystems is not a good approach. I don't recommend merging this as is.
Agreed. In any case it's not a bug fix and thus will not go into 1.3.0.
Ideally, the whole filesystem handling should be reworked into a single API, but I understand that it's a non-trivial amount of work. However, at the very least, ROMFS should be configured with a separate CONFIG_xxx macro.
Agreed, too.
/* check partition type for cramfs */fsname = (cramfs_check(part) ? "CRAMFS" : "JFFS2");
/* check partition type for JFFS2, cramfs, romfs */if (cramfs_check(part)) {fsname = "CRAMFS";} else if (romfs_check(part)) {fsname = "ROMFS";} else {fsname = "JFFS2";}This will get unwieldy in a real hurry. This should probably be reworked into a table of filesystem handlers which binds all the driver callbacks.
Indeed.
Best regards,
Wolfgang Denk