Dear Steve Sakoman,
In message 1276898035.15574.235.camel@quadra you wrote:
On Fri, 2010-06-18 at 16:10 -0500, Peter Tyser wrote:
...
It'd be preferred if you could reorganize the patch series to first make all CPU/SOC changes, then finally do 1 patch for each board. This is generally considered cleaner than having patches bouncing back and forth between common and board specific code. Right now the SDP and Panda boards each require 3 patches when 1 patch apiece should suffice. eg: ARM: Rename arch/arm/cpu/arm_cortexa8 to armv7 ARMV7: Add basic support for TI OMAP4 ARMV7: Restructure OMAP mmc driver to allow code sharing between OMAP3 and OMAP4 ARMV7: Restructure OMAP i2c driver to allow code sharing between OMAP3 and OMAP4 ARMV7: Add support for TI OMAP4430 SDP ARMV7: Add support for TI OMAP4 Panda
In the past I've had complaints that I should break each piece of functionality into a separate patch :-)
Well, the rules are formulated as clear as I could (improvments always welcome!) - please see "General Patch Submission Rules" bullet # 2 at http://www.denx.de/wiki/U-Boot/Patches
I'm happy to do whatever is preferred! Wolfgang, would you like a v4 with the proposed structure?
Yes, please. Peter is absolutely right. And please keep in mind that at each step in your patch series the code must be buildable and runnable, so we can use git bisect to isolate problems.
Best regards,
Wolfgang Denk