Re: [U-Boot] [PATCH v7 3/4] OMAP: networking support for SPL

Hi Ilya,

On Tue, Sep 18, 2012 at 5:22 AM, Ilya Yanok ilya.yanok@cogentembedded.com wrote:

This patch adds support for networking in SPL. Some devices are capable of loading SPL via network so it makes sense to load the main U-Boot binary via network too. This patch tries to use existing network code as much as possible. Unfortunately, it depends on environment which in turn depends on other code so SPL size is increased significantly. No effort was done to decouple network code and environment so far.

Signed-off-by: Ilya Yanok ilya.yanok@cogentembedded.com

---

Changes in v3:

• use BOOTP in SPL regardless of CONFIG_CMD_DHCP
• add support for setting different VCI in SPL

Changes in v4:

• fix compilation of SPL's libcommon with CONFIG_HUSH_PARSER and CONFIG_BOOTD defined
• rename spl_eth.c to spl_net.c
• set ethact variable if device name is passed

Changes in v5:

• set up guards in cmd_nvedit.c more carefully
• now we don't need command.c and only need main.c for show_boot_progress() so defined it to be noop and remove both files from SPL sources
• SPL guards in command.c and main.c are no longer needed
• add some guards in env_common.c
• qsort.c is no longer needed
• add guard to hashtable.c to save some space
• undefine unneeded CONFIG_CMD_* while building SPL to save space

Changes in v6:

• remove some unneeded changes introduced by earlier versions
• switch clauses and use ifdef instead of ifndef
• create new header config_uncmd_spl.h which undefines CONFIG_CMD_* options unneeded in SPL and include it last from config.h
• remove explicit undefs from net/net.c and net/bootp.c

Changes in v7:

• remove explicit cmd undef from net/tftp.c also
• add GPLv2 header to config_uncmd_spl.h
• remove CONFIG_SPL_BUILD clause at hang() (not needed)

Acked-by: Joe Hershberger joe.hershberger@ni.com