Re: [U-Boot] [PATCH 2/7] fdt: add "fdt sign" command

Hello Wolfgang,

Am 27.01.2014 07:50, schrieb Wolfgang Denk:

Dear Heiko,

In message52E5FE93.2030306@denx.de you wrote:

...

...

...

•           cfg_noffset = fit_conf_get_node(working_fdt, NULL);
  

•           if (!cfg_noffset)
  

•                   return CMD_RET_FAILURE;
  

May need to print an error here, since otherwise it won't be clear what went wrong.

Hmm... fit_conf_get_node() prints a dedicated error message if debug is

                                                           ^^^^^^^^^^^

...

activated... I thought this is enough ... ?

^^^^^^^^^

But in production versions (with debug NOT enabled) the user would never know what went wrong?

Good argument, so, add an error message in next patch version.

bye, Heiko