Chris,
Thanks for the update. I didn't receive all the patches but well, a couple of comments below.
-----Message d'origine----- De : Chris Packham [mailto:judge.packham@gmail.com] Envoyé : lundi 12 octobre 2015 09:43 À : u-boot@lists.denx.de; Joe Hershberger Cc : jp.tosoni@acksys.fr; hannah@marvell.com; Angga; Chris Packham; Tom Rini; Simon Glass; Masahiro Yamada Objet : [RFC PATCH 0/8] IPv6 support
This series adds basic IPv6 support to U-boot. It is a reboot of my earlier work on this[1]. Technically this is v4 of the series but with the amount of time that has passed, rebasing and running though checkpatch as well as the support for TFTP I've decided to reset the counter back to 1.
Most of this is ported from Allied Telesis' additions to u-boot[2]. (Note that I am employed by Allied Telesis[3]). The hard work was done some time ago by Angga, I've cleaned it up and made some improvements with the hope of getting it accepted upstream.
A few open issues/questions
- Presumably the majority of the actual V6 code would be included by a
config option. How far should I take that? Should the vsprintf code be conditional? I'm also not sure where to draw the line between CONFIG_NET6 and CONFIG_CMD_NET6, CONFIG_NET and CONFIG_CMD_NET look similarly confused.
If possible vsprintf code should be a different conditional since it could be used for other purpose than in IPv6 frames processing; ie. CONFIG_FORMAT_IP6 ?
- This code parallels net.c and net.h. Should I continue this for the
final version or integrate it into net.[ch].
Net.c is already big and most of your changes look independent. I would keep net6.c separate. Maybe in an ideal future, split net.c into net4.c and net.c ?
(...)
Regards, Jean-Pierre Tosoni