Hello Pali,
On 11.01.23 01:12, Pali Rohár wrote:
On Friday 06 January 2023 17:13:41 Simon Glass wrote:
Hi Pali,
On Tue, 3 Jan 2023 at 10:05, Pali Rohár pali@kernel.org wrote:
On Tuesday 03 January 2023 11:02:17 Simon Glass wrote:
>> 3. Add a common binman image for u-boot.bin (used by every board) > > It should be u-boot-dtb.bin (not u-boot.bin). At least this is the > current file name. (See this my patch series again, which aligns this > naming also for powerpc/mpc85xx).
We changed this 6 years ago and I'm not keen on going back.
ad1ecd2063d fdt: Build a U-Boot binary without device tree
I just do not understand you because in that commit is exactly what I wrote. In file u-boot-dtb.bin is u-boot binary with DTB and in file u-boot-nodtb.bin is u-boot binary without DTB.
So binman should take input files u-boot-nodtb.bin and DTB binary. And should produce output file u-boot-dtb.bin. Is there any issue with it?
Actually u-boot-dtb.bin is a hangover from that commit, left in to allow people to adjust. So I think we should remove creation of u-boot-dtb.bin
Ok, complete remove of u-boot-dtb.bin creation also works.
OK good.
- Simon
I would suggest to take patch 1/2 to have all mpc85xx boards standard output file u-boot.bin. And prevent to repeat issue that building of the final image with custom name was unintentionally turned off as a side effect of some change.
I just tried the patches (based on my rework of socrates board):
http://patchwork.ozlabs.org/project/uboot/patch/20221228200437.30971-1-pali@... http://patchwork.ozlabs.org/project/uboot/patch/20221228200437.30971-2-pali@...
and they work fine for me...
bye, Heiko