On Tue, Jan 15, 2019 at 08:58:58AM +0100, Lukasz Majewski wrote:
Hi Tom,
On Mon, Jan 14, 2019 at 03:17:20PM +0100, Lukasz Majewski wrote:
This property is necessary to allow pinctrl configuration before relocation (uart, DDR pins).
Separate file will facilitate updating vf.dtsi from the Linux kernel.
Signed-off-by: Lukasz Majewski lukma@denx.de
arch/arm/dts/vf-u-boot.dtsi | 11 +++++++++++ arch/arm/dts/vf.dtsi | 1 + 2 files changed, 12 insertions(+) create mode 100644 arch/arm/dts/vf-u-boot.dtsi
We should call the file 'vf610-u-boot.dtsi' which will get it automatically included in all vf610 platforms but still allow boards that need their own -u-boot.dtsi file to #include vf610-u-boot.dtsi
Please forgive me but I do have a hard time to parse the above sentence.
Do you propose to:
- Rename vf-u-boot.dtsi -> vf610-u-boot.dtsi ?
And then just include it in the generic (easily ported from Linux) vf.dtsi file?
or
- Shall I rename vf-u-boot.dtsi -> vf610-u-boot.dtsi and then do not
include it into vf.dtsi, but it shall be included in board dts files (like bk4.dtsi) ?
Neither exactly. See scripts/Makefile.lib for the rules that automatically pick up various -u-boot.dtsi suffixed files. "vf610" will be picked up and "vf" will not. You do _not_ need include it in other non "-u-boot.dtsi" files. You will likely end up with vf610-bk4-u-boot.dtsi or something to both set stdout-path under /chosen and #include vf610-u-boot.dtsi. If you don't need a board specific -u-boot.dtsi file then just vf610-u-boot.dtsi gets picked up automatically and you're done.