Hi Bin, On Mon, Aug 02, 2021 at 05:01:07PM +0800, Bin Meng wrote:
Hi Leo,
On Mon, Aug 2, 2021 at 4:50 PM Leo Liang ycliang@andestech.com wrote:
Hi Bin,
On Wed, Jul 28, 2021 at 05:18:59PM +0800, Bin Meng wrote:
On Wed, Jul 28, 2021 at 5:03 PM Heinrich Schuchardt xypron.glpk@gmx.de wrote:
nits: missing
Could you explain what is missing here? I did not quite catch the point, thanks!
Missing the 2nd line I mentioned in my previous email:
Do you mean that there is supposed to be a sentence but it is missing now? If so then got it, let's wait for Heinrich's comment.
From: Heinrich Schuchardt heinrich.schuchardt@canonical.com
From: Heinrich Schuchardt heinrich.schuchardt@canonical.com
We should not use /dev/sda and /dev/sdb in our examples. Users might inadvertently mess up their workstation. Use /dev/sdX instead.
Remove console output like '# ' and '> ' which makes copying hard.
Set example language to bash for correct syntax-highlighting.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
doc/board/sifive/unleashed.rst | 20 ++++++++++---------- doc/board/sifive/unmatched.rst | 30 +++++++++++++++--------------- 2 files changed, 25 insertions(+), 25 deletions(-)
Otherwise Reviewed-by: Bin Meng bmeng.cn@gmail.com
Regards, Bin
Best regards, Leo