12 Sep
2024
12 Sep
'24
2:59 a.m.
On Mon, 9 Sept 2024 at 16:27, Mikhail Kshevetskiy mikhail.kshevetskiy@iopsys.eu wrote:
The wget test seriously broken:
- Uses zero values for ISS and IRS values (see RFC 9293).
- Writes incorrect values to Sequence and Acknowledgment numbers fields of tcp packets. In the real life such packets will break the tcp stream.
- The test should fail (see above), but due to buggy old tcp implementation it passes.
This patch fix all bugs mentioned above, so the test passes with new and better tcp implementation.
Signed-off-by: Mikhail Kshevetskiy mikhail.kshevetskiy@iopsys.eu
arch/sandbox/include/asm/eth.h | 4 +++ test/cmd/wget.c | 45 ++++++++++++++++++++++++---------- 2 files changed, 36 insertions(+), 13 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
Thanks for tidying this up