On Mon, 20 Feb 2017 12:12:05 +0530 Lokesh Vutla lokeshvutla@ti.com wrote:
On Monday 20 February 2017 03:54 AM, Lukasz Majewski wrote:
This patch removes some legacy code inherited from omap4. It is redundant to the code already available in ./drivers/watchdog/omap_wdt.c
The code dates back to 2010: "ARMV7: Add basic support for TI OMAP4" SHA1: d34efc767d26d353e0257042080eec7012e5440f
In contemporary u-boot omap watchdog:
- Can be enabled in SPL:
TI watchdog is initialized in spl_board_init() (call to hw_watchdog_init)
Is explicitly disabled before making any changes of its registers
Is re-enabled in init_func_watchdog_init() in ./common/board_f.c
with other architectures.
This patch removes silent watchdog disable on TI platform, which caused lack of wdt protection in u-boot even when it was explicitly enabled (in SPL) with CONFIG_HW_WATCHDOG.
Signed-off-by: Lukasz Majewski lukma@denx.de
Can you remove similar code from arch/arm/mach-omap2/am33xx/board.c also?
Ok, I will do it (and test on BBB).
Please test/review other patches :-)
Thanks and regards, Lokesh
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de