Re: [U-Boot] [PATCH v2 20/22] omap: spl: add FAT support over MMC

Dear Aneesh V,

In message 1305472900-4004-21-git-send-email-aneesh@ti.com you wrote:

Signed-off-by: Aneesh V aneesh@ti.com

V2:

• Changes for make file changes

---

include/configs/omap4_sdp4430.h | 1 + spl/board/ti/omap4.mk | 7 +++++++ spl/board/ti/spl-omap.c | 22 ++++++++++++++++++++++ 3 files changed, 30 insertions(+), 0 deletions(-)

...

• err = file_fat_read("u-boot.bin", (u8 *)CONFIG_SYS_TEXT_BASE, 0);

Please do not hard code the file name here. Keep the code flexible and allow for other possibilities, too. At the very least, make this compile-time selectable.

Best regards,

Wolfgang Denk