
30 Oct
2014
30 Oct
'14
11:16 p.m.
On Tue, 28 Oct 2014 11:32:24 +0100 Stefan Roese sr@denx.de wrote:
This patch fixes a compilation warning of kwbimage.c:
tools/kwbimage.c: In function ‘kwbimage_set_header’: tools/kwbimage.c:784:8: warning: ‘headersz’ may be used uninitialized in this function [-Wmaybe-uninitialized] memcpy(ptr, image, headersz); ^ Instead of using multiple if statements, use a switch statement with a default entry. And return with error if an unsupported version is configured in the cfg file.
Signed-off-by: Stefan Roese sr@denx.de
v2:
- Change error message so that it really makes sense (unsupported version instead of no version)
- Change this also in the commit text
- Small change (s/is/if)
tools/kwbimage.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-)
Applied to u-boot-staging. Thanks!
Anatolij