Hello Tom,
Am 02.06.2013 15:08, schrieb Tom Rini:
On Sun, Jun 02, 2013 at 07:20:50AM +0200, Heiko Schocher wrote:
Hello Lubomir,
Am 01.06.2013 18:44, schrieb Lubomir Popov:
New i2c_read, i2c_write and i2c_probe functions, tested on OMAP4 (4430/60/70), OMAP5 (5430) and AM335X (3359); should work on older OMAPs and derivatives as well. The only anticipated exception would be the OMAP2420, which shall require driver modification.
[...9
Just one comment: Your patch has 9 checkpatch warnings which are all lines (printf strings) over 80 chars ... some with lines > 110 characters ... I know, tom gave you a OK for this ... I am also unhappy with splitting a printf-string over 2 or more lines ... but we have this 80 characters rule ... Wolfgang, what do you think? Should we loosen this rule for printf-strings?
We have loosened the rule for printf strings already, in order to make it easier for tracking down error messages. However, checkpatch needs tweaking at times for our print functions vs kernel print functions.
Ok, great, missed that, thanks!
bye, Heiko