Hi,
On 05/19/2015 04:54 PM, Siarhei Siamashka wrote:
On Tue, 19 May 2015 14:56:39 +0200 Hans de Goede hdegoede@redhat.com wrote:
Make DRAM_ODT_EN Kconfig setting a bool, add a separate DRAM_ODT_CORRECTION setting for A23 SoCs and use DRAM_ODT_EN Kconfig everywhere instead of only in dram_sun4i.c and hardcoding odt_en elsewhere.
Note this commit makes no functional changes for existing boards, its purpose is to allow changing the odt_en value on future A33 boards.
Signed-off-by: Hans de Goede hdegoede@redhat.com
The sun4i part is fine.
Regarding the A23 part, the only nitpick from me is the newly added CONFIG_DRAM_ODT_CORRECTION option. The description does not seem to be very informative in Kconfig:
+if MACH_SUN8I_A23 +config DRAM_ODT_CORRECTION
- int "sunxi dram odt correction value"
- default 0
- ---help---
- Set the dram odt correction value (range -255 - 255).
+endif
Since the right correction value is extracted from the FEX file (or where are we expected to get it from?), a short instruction about converting the 'dram_odt_en' parameter from FEX into the DRAM_ODT_CORRECTION option for U-Boot would be quite useful here.
Thanks for the review, adding a blurb to the Kconfig help on how to get the correction value from a fex file is a good idea, I've added such a blurb to the version in my personal tree.
Regards,
Hans