On Thu, May 28, 2015 at 11:23 PM, Maxime Ripard maxime.ripard@free-electrons.com wrote:
On Thu, May 28, 2015 at 09:25:29PM +0800, Chen-Yu Tsai wrote:
The PSCI CPU_ON code accesses quite a few registers. Document their names to make it easier to cross reference.
Also explain "lock cpu" and "unlock cpu" as enabling/disabling debug access.
Signed-off-by: Chen-Yu Tsai wens@csie.org
arch/arm/cpu/armv7/sunxi/psci.S | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/cpu/armv7/sunxi/psci.S b/arch/arm/cpu/armv7/sunxi/psci.S index 7ec0500..bbfeec8 100644 --- a/arch/arm/cpu/armv7/sunxi/psci.S +++ b/arch/arm/cpu/armv7/sunxi/psci.S @@ -165,12 +165,12 @@ psci_cpu_on: str r6, [r5] @ Reset CPU
@ l1 invalidate
ldr r6, [r0, #0x184]
ldr r6, [r0, #0x184] @ CPUCFG_GEN_CTRL_REGCan't we use some defines instead? You seem to do that on a few registers (mostly the GIC's), why not for these?
Sure. Though to be clear GIC wasn't my work. :p
For sun6i there's a bit of offset calculating, so we can't use defines for them all.
ChenYu