Dear "V, Aneesh",
In message FF55437E1F14DA4BAEB721A458B6701706BD8CC798@dbde02.ent.ti.com you wrote:
And: no spaces after function names please (fix globally!).
But how about this rule mentioned in your wiki:
"All contributions to U-Boot should conform to the Linux kernel coding styl e; see the file "Documentation/CodingStyle" and the script "scripts/Lindent " in your Linux kernel source directory. In sources originating from U-Boot a style corresponding to "Lindent -pcs" (adding spaces before parameters t o function calls) is actually used."
[Could you please restrict your ine length to some 70 characters or so? Thanks!]
http://www.denx.de/wiki/U-Boot/CodingStyle
In fact, I didn't add spaces initially. They got added when I ran "Lindent -pcs". Is this rule not applicable anymore? Or am I missing something?
Thais was written some time ago by me, and nobody cared to fix it yet. Having the spaces was (and is) my ownporeferred style, but I got overruled by a vast majority...
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Sunday, June 06, 2010 1:25 AM To: V, Aneesh Cc: u-boot@lists.denx.de; olbpdev@list.ti.com - OMAP Linux Baseport Development Team (May contain non-TIers) Subject: Re: [U-Boot] [PATCH 2/2] arm: cortexa9: adding support for TI OMAP4430 SDP
Dear Aneesh V,
And please don;t top-post / full quote; please see http://www.netmeister.org/news/learn2quote.html
Best regards,
Wolfgang Denk