On Friday, April 18, 2014 at 06:14:26 PM, Wolfgang Denk wrote:
Dear Rob,
In message 1397829272-22266-1-git-send-email-robherring2@gmail.com you
wrote:
I dropped the patch adding a loadsize env variable and added config uptions instead to set the fastboot buffer size.
Thanks, but...
common/Makefile | 3 + common/cmd_bootm.c | 23 +- common/cmd_fastboot.c | 36 +++ common/image-android.c | 84 ++++++ common/image.c | 20 +- doc/README.android-fastboot | 91 ++++++ doc/README.android-fastboot-protocol | 170 ++++++++++++ drivers/usb/gadget/Makefile | 1 + drivers/usb/gadget/f_fastboot.c | 518 +++++++++++++++++++++++++++++++++++ drivers/usb/gadget/g_dnl.c | 6 + drivers/usb/gadget/usbstring.c | 3 + drivers/usb/musb-new/musb_uboot.c | 5 +- include/android_image.h | 69 +++++ include/configs/omap3_beagle.h | 10 + include/fastboot.h | 22 ++ include/image.h | 13 + 16 files changed, 1067 insertions(+), 7 deletions(-)
...I don't see the README in the list of modified files - but new CONFIG options _must_ be documented there. So please add the missing documentation.
I reviewed the patches again. I am with WD on this, please add the changes to the README file.
Other than that, I applied 1/5 and 3/5 now as they are clearly fixes and can go in. Please rebase on top of u-boot-usb/master and re-submit the rest.
Thanks!
Best regards, Marek Vasut