
Dear Stefano Babic,
[...]
Given that the PSU regs for example have completely different register map and bit maps in the registers itself, I'd be careful with the renaming.
Personally I prefer that the function names are the same and the implementation itself of the function hides the SOC details.
Sure, I was just pointing out the PSU regs differ on MX23 and MX28 ... so maybe we should have separate regs-mx28-power.h and regs-mx23-power.h. But then it'd be troublesome to make the code generic enough (not full of ifdefs). On the other hand, if both those header files contained reg. structures named the same and were included based on the CPU type, that might just work.
In this way, we provide the same interface API to the user (=the board maintainer) and to the drivers that are surely shared between the MX28 and MX23.
Of course.
Best regards, Stefano Babic
Best regards, Marek Vasut