Re: [U-Boot] [PATCH 01/11] fw_env.c: Increase max dev path to 32

Dear Tom Rini,

In message 1380227287-26057-2-git-send-email-trini@ti.com you wrote:

Currently our limit is too small to allow for /dev/mmcblk0boot0 to work, for example. Expand to 32 for future needs.

Signed-off-by: Tom Rini trini@ti.com

tools/env/fw_env.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index 577ce2d..bf5c552 100644 --- a/tools/env/fw_env.c +++ b/tools/env/fw_env.c @@ -40,7 +40,7 @@ _min1 < _min2 ? _min1 : _min2; })

struct envdev_s {

• char devname[16]; /* Device name */

• char devname[32]; /* Device name */

Do we really need a static size here? Can we not auto-adjust to the needed size, say by dynamically allocating the buffer?

Best regards,

Wolfgang Denk