On Wednesday 20 July 2022 08:06:28 Heiko Thiery wrote:
Hi,
Am Di., 19. Juli 2022 um 21:20 Uhr schrieb Pali Rohár pali@kernel.org:
On Tuesday 19 July 2022 20:38:39 Heiko Thiery wrote:
Instead of hardcoding -ltinfo as the flags needed to build kwboot, use pkg-config when available.
We gracefully fallback on the previous behavior of hardcoding -ltinfo if pkg-config is not available or fails with an error.
Signed-off-by: Heiko Thiery heiko.thiery@gmail.com
So... in current form this patch is OK.
I already sent a v2 that introduced the cflags. I will send a v3 that removes adding this again. Ok?
Ou, sorry for that :-(
Anyway, details about this issue are described here: https://source.denx.de/u-boot/u-boot/-/blob/master/tools/termios_linux.h https://source.denx.de/u-boot/u-boot/-/commit/e8d26e8276358fcd1c2fe28293d3b4...
Reviewed-by: Pali Rohár pali@kernel.org
tools/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile index 9f6b282ad8..45195a8ce7 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -198,7 +198,9 @@ hostprogs-$(CONFIG_EXYNOS5420) += mkexynosspl HOSTCFLAGS_mkexynosspl.o := -pedantic
HOSTCFLAGS_kwboot.o += -pthread -HOSTLDLIBS_kwboot += -pthread -ltinfo +HOSTLDLIBS_kwboot += -pthread +HOSTLDLIBS_kwboot += \
$(shell pkg-config --libs tinfo 2> /dev/null || echo "-ltinfo")ifdtool-objs := $(LIBFDT_OBJS) ifdtool.o hostprogs-$(CONFIG_X86) += ifdtool -- 2.30.2