Re: [U-Boot] [RFC PATCH 32/44] image: Support signing of images

Dear Simon Glass,

[...]

• int string_size;
• int ret;
• /*

• * Get the current string size, before we update the FIT and add
  

• * more
  

• */
  

• string_size = fdt_size_dt_strings(fit);
• ret = fdt_setprop(fit, noffset, FIT_VALUE_PROP, value, value_len);
• ret |= fdt_setprop_string(fit, noffset, "signer-name", "mkimage");
• ret |= fdt_setprop_string(fit, noffset, "signer-version",

• 		  PLAIN_VERSION);
  

Can you really be ORR'ing a signed variable such as "ret" ? [...] Best regards, Marek Vasut