
Dear Stefano, Anatolij, Scott,
On 18.04.2012 13:47, Stefano Babic wrote:
On 18/04/2012 10:54, Timo Ketola wrote:
Signed-off-by: Timo Ketola timo@exertus.fi
...
diff --git a/drivers/video/mx2fb.c b/drivers/video/mx2fb.c new file mode 100644 index 0000000..9ee4a3e
IMHO it is better if you use the video API instead of the old LCD interface, that means using CONFIG_VIDEO. You have then to implement a video_hw_init() function for your initialisation. I think there are advantages doing that, and recently some drivers moved to this API, for example the driver for i.MX3 (mx3fb.c).
I agree on that but unfortunately I'm short on time. What if I implement the driver in my board folder instead? I suppose there is not too much interest to get generic LCD support for i.MX2 because it is not yet there and architecture is a little oldish.
There should still be register definitions in the imx-regs.h like I propose in this patch. Or should I keep them too in my board folder?
Timo Ketola (1): i.MX25: lcdc: Add register definitions
arch/arm/include/asm/arch-mx25/imx-regs.h | 32 +++++++++++++++++++++++++++++ 1 files changed, 32 insertions(+), 0 deletions(-)