Re: [U-Boot] [PATCH] ppc4xx: Fix msg "initialization as root-complex failed" upon PCIe scan

Dear Stefan Roese,

In message 200910021450.19551.sr@denx.de you wrote:

...

But looking at this patch, it seems that larger parts in this (supposedly) board-specific code are actually more or less identical.

Should we not factor out such common code?

Yes, this could (should) be done. But there are differences in these board specific functions. This consolidation could introduce new errors/bugs. And I didn't want to do such a thing, now that the merge window is closed. And

I did not intend to ask for this fior the current release.

frankly, I don't have the time for such a cleanup right now. But I'll put this on my to-do list.

Thanks.

Best regards,

Wolfgang Denk