
Andrew Klossner wrote:
The compiler will help find mismatches between printf formats and arguments if you let it. This patch adds the necessary attributes to declarations in include/common.h, then corrects the resulting compiler warnings in several files. Some of these were bugs, e.g., "$d" instead of "%d" and incorrect arguments in common/cmd_fdt.c. Others were just annoying, like int-long mismatches on a system where both are 32 bits. It's worth fixing the annoying errors to catch the real ones.
I can only compile for ppc architecture so have not tested much of the source code for further warnings.
common/cmd_fdt.c
cmd_fdt.c portion... Acked-by: Gerald Van Baren vanbaren@cideas.com
I'm embarrassed by the number of bugs I wrote into that function and apologize for being so sloppy. My thanks to Andrew and others for finding and fixing my screwups. :-(
Best regards, gvb