31 Mar
2008
31 Mar
'08
9:37 a.m.
Don't do this.
I don't think the ATA_SECT_BYTESIZE is better than the ATA_SECT_SIZE.
The big problem here is that ata.h defines ATA_SECT_SIZE as 256 Words where libata defines it as 512 Bytes.
I did not want to change the old define since it would possibly break more than the fsl driver.
When I grep 'ATA_SECT_SIZE', I can *not* find any files including the ATA_SECT_SIZE before the fsl_sata.c.
But the problem still remains, it is currently impossible to use both libata.h and ata.h.
Why need use both them? I believe the libata.h is enough.
If the libata.h is not enough for you, I suggest you update it from the latest linux kernel.
I think it is correct way to handle it. It will be more easy to to maintain the header.