On 26 March 2015 15:18:56 CET, Stephen Warren swarren@wwwdotorg.org wrote:
I assume all the white-space and line reordering changes are so that a diff of colibri_t20.h and colibri_t30.h shows minimal differences?
Exactly.
-#define CONFIG_CMD_NFS -#define CONFIG_CMD_PING
It might warrant some explanation why those appear to be removed. Are they enabled by default anyway?
NFS is actually explicitly undefined in tegra-common and we never ever used from within U-Boot before.
And PING gets already pulled in by the distro_defaults.
Is any of that generally useful to other boards; do we want to add those lines to tegra*-common*.h instead?
(IIRC some of the command-line size related variables enable the ridiculously long kernel command-lines required to boot our downstream kernel, so would be useful on at least some other boards. Hence, enabling everywhere might be simplest).
Remember I already got those added to our Apalis and Colibri T30 configurations. We require it for our update scripts as well as to boot downstream L4T. So if you deem that useful in general sure, I can as well cook up a patch for that.