Hi Wolfgang,
Dear ap@denx.de,
In message 1227214731-19542-3-git-send-email-ap@denx.de you wrote:
From: Andreas Pfefferle ap@denx.de
This patch adds the board specific communication routines needed by the external 4543 RTC.
No, that's broken by design. An RTC is not board-dependent, but a generic piece of hardware. Code for it does not belong into any board-specific file, but into drivers/rtc/
Did you actually check what he does?
He does exactly what you request, he puts all the 4543 code into drivers/rtc, but this cannot globally encode on how to access the chip from a specific hardware. So he factored that out of the rtc driver (correctly in my opinion) and has only this glue code in the board files.
What *exactly* is broken by design in this approach?
Cheers Detlev