Re: [PATCH] odroid: add CROS_EC to odroid_defconfig

Hi Joost,

[ ... ]

...

That would be OK too, but if you do that, please use IS_ENABLED() rather than #ifdef

I've tested the alternative, and that works for me as well. I am slightly in favour of the alternative, because it seems illogical to require building a driver that is never going to be used. On the other hand this patch only affects the Odroid U2, and the alternative every board using an Exnyos chip.

I'm still wondering why other boards, e.g. the Odroid XU3, are seemingly (I don't have any) unaffected by this.

Odroid-xu4 has the same issue, and the proposed solutions fixes the issue there as well. I also think the alternative `#if IS_ENABLED(CONFIG_CROS_EC)`-solution would be better.

Thanks for reporting the issue!

Best regards, Henrik Grimler