On Wed, May 1, 2019 at 8:13 PM Bin Meng bmeng.cn@gmail.com wrote:
On Fri, Apr 26, 2019 at 11:59 AM Simon Glass sjg@chromium.org wrote:
At present only OF_SEPARATE is considered valid for building a device-tree file in SPL. However sandbox uses OF_HOSTFILE instead. Update the logic to handle this and make it easier to understand.
Note that the new logic is not quite the same as the old logic. It was previously assumed that checking for:
$(CONFIG_$(SPL_TPL_)OF_CONTROL) $(CONFIG_OF_SEPARATE) $(CONFIG_$(SPL_TPL_)OF_PLATDATA)
producing 'yy' meant that the first two were 'y' and the last was empty. Strictly speaking it would be possible for any two of the three to be 'y' and still yield the same result. However, that was not the intention of the new logic, since OF_PLATDATA always ensures that no device-tree file is included. So in effect the new logic is the same, with the addition of OF_HOSTFILE as an option for OP_SEPARATE.
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2:
- Add a better explanation of the logic change, in the commit message
scripts/Makefile.spl | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!