
Dear Pantelis,
in message DE665B74-967F-486A-B382-C83196EC8D03@embeddedalley.com you wrote:
Well, here's the thing, if the board's DRAM is not soldered properly this will probably trigger - think of it as a cheap memory test.
Well, you would see the unexpected size printed with the startup messages. That's something you should always look for: memory sizes, clock frequencies, etc.
Please don't do this. Let's clean this up and use one common verion - if needed at all, as there is other memtest code, too.
Well, there is not a common memory test code. I could move this to a
Wrong, there is.
First, there is common/memsize.c which includes a simple but pretty efficient (and fast) memory test.
Then there is common/cmd_mem.c with it's two different implementations of do_mem_mtest(), depending if CFG_ALT_MEMTEST is set or not.
And finally, there is post/memory.c which is where you copied the code from. Why didn't you use post/memory.c ?
area. But I'll only modify this board to use it; the rest is the job of their respective maintainers.
Agreed.
Best regards,
Wolfgang Denk