Re: [U-Boot] [PATCH v3 1/3] env: correct the check of env_flags_validate presence

On Wed, 18 Sep 2019 at 03:30, Patrick Delaunay patrick.delaunay@st.com wrote:

This patch corrects the check of env_flags_validate presence because "flags.c" is always compiled in U-Boot and CONFIG_ENV_SUPPORT don't exist; so the macro CONFIG_IS_ENABLED(ENV_SUPPORT) only provides the expected result for SPL and TPL (check activation of CONFIG_SPL_ENV_SUPPORT and CONFIG_TPL_ENV_SUPPORT).

This patch solves the regression introduced by commit 7d4776545b0f ("env: solve compilation error in SPL"); change_ok was always NULL in U-Boot.

Signed-off-by: Patrick Delaunay patrick.delaunay@st.com

Changes in v3: None Changes in v2: None

env/common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org