Re: [PATCH v3 4/7] binman: bintool: parametrize args to pass to binary for returning version

1 Sep 2022


      On Thu, 1 Sept 2022 at 09:52, Quentin Schulz foss+uboot@0leil.net wrote:
...
From: Quentin Schulz quentin.schulz@theobroma-systems.com
The code to check the version is very similar between binaries, the most
likely only needed variables are the regex to find the version (already
supported) and the args to pass to the binary so that it prints this
version (e.g. --version, -V or similar).
Let's make it a parameter of Bintool so that code duplication can be
avoided for simple changes.
Signed-off-by: Quentin Schulz quentin.schulz@theobroma-systems.com
v3:

rename version_parameters into version_args,

added in v2
tools/binman/bintool.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org