1 Apr
2020
1 Apr
'20
10:06 a.m.
Hi Patrick
On 3/31/20 6:04 PM, Patrick Delaunay wrote:
This patch avoids crash in strcmp when the boot_device is not present in environment (this case should be never occur)
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
board/st/stm32mp1/stm32mp1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c index 89a088cd28..fff4cef2c2 100644 --- a/board/st/stm32mp1/stm32mp1.c +++ b/board/st/stm32mp1/stm32mp1.c @@ -753,7 +753,8 @@ int board_late_init(void)
/* Check the boot-source to disable bootdelay */ boot_device = env_get("boot_device");
- if (!strcmp(boot_device, "serial") || !strcmp(boot_device, "usb"))
if (boot_device &&
(!strcmp(boot_device, "serial") || !strcmp(boot_device, "usb")))env_set("bootdelay", "0");
return 0;
Reviewed-by: Patrice Chotard patrice.chotard@st.com
Thanks