On 07/03/2020 15:30, Amit Tomer wrote:
Hi,
Both those include files do not exist yet. This breaks bisectability for bubblegum_96. So I would suggest you remove the s700 lines for now, and change the s900 filename to match the existing one. Then change CLK_UART<x> to CLOCK_UART<x> below to make it compile.
Please check that bubblegum_96_defconfig still builds after *every* commit.
Once you sync up the binding include file for S900 later on, you should revert those changes back in the same commit.
Did you mean, I should first send sync up the binding patches and patch 5/11, then this particular(common clock driver) patch ?
There are several ways to solve this problem, I sketched one solution above (which I compile tested), this lets you keep the order.
But I think there are more ordering issues in this series, for instance you introduce S700 support to the build system quite early (04/11), but are not fully ready yet. Without double checking this, I would suggest: 1, 2, 7, 8, 3, 9, 5, 6, 4, 10, 11. With slight adjustments to 3 like mentioned above. bubblegum_96 must compile cleanly after every patch, and you should not be able to select S700 or Cubie7 until it's ready.
Cheers, Andre