Hi Stefan,
On Fri, Jun 1, 2012 at 7:55 AM, Stefan Roese sr@denx.de wrote:
Joe,
On Wednesday 09 May 2012 11:36:56 Stefan Roese wrote:
+++ b/include/configs/spear-common.h @@ -38,6 +38,7 @@
#define CONFIG_NET_MULTI #define CONFIG_PHY_RESET_DELAY 10000 /*
in usec */
#define CONFIG_DW_AUTONEG
+#define CONFIG_PHY_GIGE /* Include GbE speed/duplex
detection */
Shouldn't this come in a separate patch?
Not sure. This change is needed for this change in the designware driver to really work with 1000mbps links:
- Use common functions miiphy_speed()& miiphy_duplex() to read
link status from PHY.
Splitting it into a separate commit will result in a non working ethernet driver for such links. Even though it should still compile and be git bisectable. I would prefer to keep it in one patch.
Are you okay with this patch? If yes, perhaps it would be best if I would push this patch with the other SPEAr platform patches upstream. What do you think? Can I have your Acked-by?
I'm not especially fond of adding prints, but it seems in line with the existing behavior.
Acked-by: Joe Hershberger joe.hershberger@gmail.com