Dear Peng,
-----Original Message----- From: Peng Ma Sent: Thursday, May 23, 2019 12:37 PM To: Stefan Roese sr@denx.de; Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Shengzhou Liu shengzhou.liu@nxp.com; Ruchika Gupta ruchika.gupta@nxp.com Cc: Yinbo Zhu yinbo.zhu@nxp.com; sjg@chromium.org; Jagdish Gediya jagdish.gediya@nxp.com; York Sun york.sun@nxp.com; bmeng.cn@gmail.com; make@marvell.com; Andy Tang andy.tang@nxp.com; u-boot@lists.denx.de Subject: RE: [EXT] Re: [PATCH 1/4] ata: fsl_ahci: Add sata DM support for Freescale powerpc socs
Hi Stefan,
-----Original Message----- From: Stefan Roese sr@denx.de Sent: 2019年5月23日 13:09 To: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Peng Ma peng.ma@nxp.com; Shengzhou Liu shengzhou.liu@nxp.com; Ruchika
Gupta
ruchika.gupta@nxp.com Cc: Yinbo Zhu yinbo.zhu@nxp.com; sjg@chromium.org; Jagdish Gediya jagdish.gediya@nxp.com; York Sun york.sun@nxp.com; bmeng.cn@gmail.com; make@marvell.com; Andy Tang
u-boot@lists.denx.de Subject: [EXT] Re: [PATCH 1/4] ata: fsl_ahci: Add sata DM support for Freescale powerpc socs
Caution: EXT Email
On 23.05.19 06:58, Prabhakar Kushwaha wrote:
<snip>
>>> drivers/ata/Kconfig | 10 + >>> drivers/ata/Makefile | 1 + >>> drivers/ata/fsl_ahci.c | 1030 >> ++++++++++++++++++++++++++++++++++++++++ >>> drivers/ata/fsl_sata.h | 1 + >>> 4 files changed, 1042 insertions(+) >>> create mode 100644 drivers/ata/fsl_ahci.c >> >> Will this patch series replace the old fsl_sata.c driver? If >> yes, could you remove this driver as well in this series? > [Peng Ma] > Hi Stefan, > > fsl_sata.c used to Non DM sata driver for some powerpc socs. > Currently We only have one board that supports dts initialization. > I will remove this old driver When all of our powerpc socs support DM.
I see, thanks. I just wanted to know, if this new SATA driver is a meant as a replacement for the old non-DM driver.
[Peng Ma] Hi Stefan,
I am so sorry to reply late, Other Non dts powerpc board need the old sata driver, so the new Sata driver does not replace the so far.
Just curious: Which are the "other non dts powerpc boards"? Are there still many? Is there a plan to move them to DT as well? Or should they perhaps be dropped from mainline if not converted to DT? What's stopping the conversion here?
There are too many powerpc platforms which are not migrated to DT.
My suggestion will be to have sata driver supporting both. Once all PowerPC platform using this SATA driver migrated, it can be dropped.
I'm fine with this. Please go ahead.
Ok, thanks for your review.
I am seeing build errors in drivers/ata/fsl_sata.c with this patch. Something may have changed from the time the patch has submitted and till I am trying to incorporate.
Can you please fix and provide updated patch on top of the tree as early as possible
--pk