Re: [PATCH v3] mmc: allow use of hardware partition names for mmc partconf

Hi Marek,

On Fri, Apr 26, 2024 at 5:49 PM Marek Vasut marex@denx.de wrote:

[...]

...

diff --git a/include/mmc.h b/include/mmc.h index 4b8327f1f93b..7243bd761202 100644 --- a/include/mmc.h +++ b/include/mmc.h @@ -381,6 +381,21 @@ enum mmc_voltage { #define MMC_TIMING_MMC_HS200 9 #define MMC_TIMING_MMC_HS400 10

+/* emmc hardware partition values */ +enum emmc_hwpart {

• EMMC_HWPART_DEFAULT = 0,
  

• EMMC_HWPART_BOOT0 = 1,
  

• EMMC_HWPART_BOOT1 = 2,
  

• EMMC_HWPART_GP1 = 3,
  

• EMMC_HWPART_GP2 = 4,
  

• EMMC_HWPART_GP3 = 5,
  

• EMMC_HWPART_GP4 = 6,
  

• EMMC_HWPART_USER = 7,
  

+};

+/* emmc hardware partition names */ +extern const char *emmc_hwpart_names[];

Maybe the array should have fixed size here, i.e. 8 ?

Is there an ABI reason to do so? Can you explain further why it would be needed to do that?