Re: [U-Boot] [PATCH] drivers/net/e1000.c: Fix GCC 4.6 build warnings

On Tuesday 20 December 2011 11:07:30 Moffett, Kyle D wrote:

On Dec 20, 2011, at 10:49, Anatolij Gustschin wrote:

...

#ifdef CONFIG_E1000_FALLBACK_MAC

• if ( *(u32*)(nic->enetaddr) == 0 || *(u32*)(nic->enetaddr) == ~0 ) {

• if (get_unaligned_be32(nic->enetaddr) == 0 ||

•    get_unaligned_be32(nic->enetaddr) == ~0) {
  
  

  unsigned char fb_mac[NODE_ADDRESS_SIZE] = CONFIG_E1000_FALLBACK_MAC; memcpy (nic->enetaddr, fb_mac, NODE_ADDRESS_SIZE);

No, if you are going to fix this code then make it use the right function for the job: is_valid_ether_addr()

+1 -mike