Wolfgang Denk wrote:
Dear Dirk,
In message 49108377.0305560a.52c1.39ea@mx.google.com you wrote:
Use a consistent style. Plain numbers don't need parens. Proposed by Wolfgang Denk.
Signed-off-by: Dirk Behme dirk.behme@gmail.com
...
But...
/* GPMC CS3/cs4/cs6 not avaliable */ -#define GPMC_BASE (OMAP34XX_GPMC_BASE) +#define GPMC_BASE OMAP34XX_GPMC_BASE
This is NOT a plain number.
OMAP34XX_GPMC_BASE is. Trust me, I checked it before doing this change ...
If I decide to use something like
#define OMAP34XX_GPMC_BASE FOO + BAR
you might comment that such a #define is dangerous in itself, but why not protet against it? with a number we are sure we don't need parens, but with a macro we'd should rather play safe.
... so we do play safe here. Maybe you noticed that I didn't change other places where the parens are needed as you correctly explained.
Dirk