Re: [U-Boot] [PATCH 2/5] mmc: sdhci: rework Samsung specfic code

Dear Rob Herring,

In message 1306955427-18940-3-git-send-email-robherring2@gmail.com you wrote:

From: Rob Herring rob.herring@calxeda.com

Move the register definitions into the sdhci.c file. Set the base address from the board init code.

The Samsung SDHCI controller has extra registers. Make them conditional on CONFIG_MMC_S5P.

Signed-off-by: Rob Herring rob.herring@calxeda.com

Please run your patches through checkpatch before submittint. This should have shown you this:

...

• err = s5p_mmc_init(2, 4);
  

• err = sdhci_mmc_init((void *)(samsung_get_base_mmc() + 0x20000), 4);
  

Line too long.

Best regards,

Wolfgang Denk