Hi,
On jeu., juil. 25, 2024 at 20:57, Marek Vasut marex@denx.de wrote:
On 7/25/24 8:48 PM, Zixun LI wrote:
On Thu, Jul 25, 2024 at 8:24 PM Marek Vasut marex@denx.de wrote:
On 7/25/24 5:31 PM, Zixun LI wrote:
Changes in v4:
- Release clocks if probe failed
- Add missing endpoint data free
- Addressed comments
Please collect any AB/RB/TB tags that were provided in v3 too.
Sorry didn't know that, should I spin a v5 ?
No worries, wait a few days for more feedback (if any), and then collect them for V5 and send V5.
Indeed, it's important to collect the tags to make sure that the reviewers get credit for their time reviewing.
Zixun, make sure to collect them for all future contributions.
Fortunately, b4 (https://b4.docs.kernel.org/en/latest/index.html) can collect the tags:
$ b4 shazam -s -l --check 20240725153204.358925-1-admin@hifiphile.com
[...]
✓ [PATCH v4 1/7] usb: gadget: atmel: Sort includes + Reviewed-by: Marek Vasut marex@denx.de (✓ DKIM/denx.de) + Reviewed-by: Mattijs Korpershoek mkorpershoek@baylibre.com (✓ DKIM/baylibre-com.20230601.gappssmtp.com) + Link: https://lore.kernel.org/r/20240725153204.358925-2-admin@hifiphile.com + Signed-off-by: Mattijs Korpershoek mkorpershoek@baylibre.com ● checkpatch.pl: passed all checks
So, for this series, 2 cases can happen:
1. No other review comments are found. A v5 won't be required. I will collect the tags with b4 when applying to the u-boot-dfu tree
2. New review comments require the series to be modified. A v5 is required. In that case, make sure to collect all tags yourself.
Please wait a few days for others to get time to chime in this patch series.
Thank you for your contribution !
Mattijs