Hi Quentin,
On Mon, 2 Jan 2023 at 09:42, Quentin Schulz quentin.schulz@theobroma-systems.com wrote:
Hi Simon,
On 12/22/22 00:07, Simon Glass wrote:
Enable multiple-images so we can generate more than one image. Also add a comment for the end of the #if block.
Signed-off-by: Simon Glass sjg@chromium.org
(no changes since v5)
Changes in v5:
Rename from 'Include binman script in 64-bit boards'
Drop duplicate #include in rk3368-u-boot.dtsi
Keep the name as fit for puma
Drop redundant check for CONFIG_ROCKCHIP_SPI_IMAGE
Drop imply of BINMAN in Kconfig (rely on ARCH_ROCKCHIP instead)
arch/arm/dts/rk3399-u-boot.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi index 3c1a15fe51b..85a4f472d5d 100644 --- a/arch/arm/dts/rk3399-u-boot.dtsi +++ b/arch/arm/dts/rk3399-u-boot.dtsi @@ -62,6 +62,7 @@
#if defined(CONFIG_ROCKCHIP_SPI_IMAGE) && defined(CONFIG_HAS_ROM) &binman {
multiple-images; rom { filename = "u-boot.rom"; size = <0x400000>;@@ -82,7 +83,7 @@ }; }; }; -#endif +#endif /* CONFIG_ROCKCHIP_SPI_IMAGE */
&& CONFIG_HAS_ROM
On a different topic, I'm a bit confused by this u-boot.rom binary. is it not just for Chromebooks? We now have u-boot-rockchip-spi.bin for SPI images but they are different (same as u-boot-rockchip.bin, just formatted in a way it can be flashed on a SPI flash).
The .rom is for SPI flash, not just Chromebooks. Perhaps we should unify the two of them?
Regards, Simon