On Thu, 2012-06-21 at 12:39 +0300, Roger Quadros wrote:
If board config does not select CONFIG_USB_EHCI_OMAP (e.g. omap4_sdp4430_config) then the USB DPLL is stuck in running state and it prevents the system from entering OFF mode (i.e. l3init domain is kept ON).
With this patch we unconditionally configure the USB DPLL so it functions properly even on boards not using CONFIG_USB_EHCI_OMAP
Signed-off-by: Roger Quadros rogerq@ti.com
I actually did exactly the same changes to my u-boot tree for the same reason. I don't have your neat changelog though. So, you can consider this as:
Acked-by: Tero Kristo t-kristo@ti.com
arch/arm/cpu/armv7/omap-common/clocks-common.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c b/arch/arm/cpu/armv7/omap-common/clocks-common.c index 10d286a..206f0ab 100644 --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c @@ -256,7 +256,6 @@ void configure_mpu_dpll(void) debug("MPU DPLL locked\n"); }
-#ifdef CONFIG_USB_EHCI_OMAP static void setup_usb_dpll(void) { const struct dpll_params *params; @@ -283,7 +282,6 @@ static void setup_usb_dpll(void) /* Now setup the dpll with the regular function */ do_setup_dpll(&prcm->cm_clkmode_dpll_usb, params, DPLL_LOCK, "usb"); } -#endif
static void setup_dplls(void) { @@ -317,9 +315,7 @@ static void setup_dplls(void) /* MPU dpll */ configure_mpu_dpll();
-#ifdef CONFIG_USB_EHCI_OMAP setup_usb_dpll(); -#endif }
#ifdef CONFIG_SYS_CLOCKS_ENABLE_ALL