Hi Scott,
On Wednesday 21 March 2012 10:04 PM, Scott Wood wrote:
On 03/20/2012 11:43 PM, Prabhakar Kushwaha wrote:
diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c index 091af7c..d0b15a4 100644 --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c @@ -1,5 +1,5 @@ /*
- Copyright 2009-2011 Freescale Semiconductor, Inc
- Copyright 2009-2012 Freescale Semiconductor, Inc
- This program is free software; you can redistribute it and/or
- modify it under the terms of the GNU General Public License as
@@ -53,6 +53,36 @@ void setup_ifc(void)
asm volatile("isync;msync;tlbwe;isync");
+#if defined(CONFIG_E500)&& defined(CONFIG_SYS_PPC_E500_DEBUG_TLB)
There is no need to check for CONFIG_E500 anywhere in arch/powerpc/cpu/mpc85xx. mpc85xx implies CONFIG_E500.
Ok. I will re-spin all the patches without CONFIG_E500 condition check.
I don't see anywhere in this patchset where you set CONFIG_SYS_PPC_E500_DEBUG_TLB on any actual board.
This CONFIG_SYS_PPC_E500_DEBUG_TLB is defined in arch/powerpc/include/asm/config_mpc85xx.h. i defined for P1010 (in this patch). For rest of e500 v1, v2 processor family new patch-set will be sent once this base patch is accepted.
It should be set for all e500v1/v2, not just so that debug works but so that this code remains tested.
Yes. I agree with you. It will be automatically enabled when CONFIG_SYS_PPC_E500_DEBUG_TLB is defined per SoC(e500 v1/v2). As of now only for P1010 it is enabled.
--Prabhakar