Re: [U-Boot] [PATCH] mmc: fix to assign to corret clock value when clock is enabling

Le 23/01/2018 à 06:04, Jaehoon Chung a écrit :

When clock is enabling, it's assigned to 0 as mmc->clock. Then it can't initialize any card. Fix to assign to correct clock value as mmc->cfg->f_min or f_max.

Fixes: 9546eb92cb6 ("mmc: fix the wrong disabling clock")

I tested your patch on top of u-boot-mmc and SD/MMC is working fine on snow config (Samsung Chromebook).

Tested-by: Guillaume GARDET guillaume.gardet@free.fr

Signed-off-by: Jaehoon Chung jh80.chung@samsung.com

drivers/mmc/mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 311f51f237..2d0e7bb3a2 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -1501,7 +1501,7 @@ static int mmc_set_ios(struct mmc *mmc)

int mmc_set_clock(struct mmc *mmc, uint clock, bool disable) {

• if (!disable && clock != 0) {

• if (!disable) { if (clock > mmc->cfg->f_max) clock = mmc->cfg->f_max;