On 05/08/2017 07:29 PM, Tom Rini wrote:
On Mon, May 08, 2017 at 06:36:43PM +0200, Jorge Ramirez-Ortiz wrote:
This port adds support for: 1) Serial 2) eMMC 3) USB
[snip]
arch/arm/dts/hi3798cv200.dtsi | 3 + arch/arm/dts/poplar-uboot.dtsi | 24 +++
[snip]
diff --git a/arch/arm/dts/hi3798cv200.dtsi b/arch/arm/dts/hi3798cv200.dtsi index 75865f8..caa17de 100644 --- a/arch/arm/dts/hi3798cv200.dtsi +++ b/arch/arm/dts/hi3798cv200.dtsi @@ -409,3 +409,6 @@ }; }; };
+#include "poplar-uboot.dtsi"
NAK, that's not the mechanism, we have one that will automatically include the right file. IF it's needed.
yeah I thought so...still what about what is being done for the dragonboard? (that is what misled me really) seems to me that board needs fixing as well...
diff --git a/arch/arm/dts/poplar-uboot.dtsi b/arch/arm/dts/poplar-uboot.dtsi new file mode 100644 index 0000000..8a9668a --- /dev/null +++ b/arch/arm/dts/poplar-uboot.dtsi @@ -0,0 +1,24 @@ +/*
- U-Boot addition to:
- initialize the console clock rate.
- provide support for the generic-ehci USB driver currently not available
in the linux kernel (8/May/2017).
- (C) Copyright 2017 Jorge Ramirez-Ortiz jorge.ramirez-ortiz@linaro.org
- SPDX-License-Identifier: GPL-2.0+
- */
+&soc {
- usb2: ehci@9890000 {
compatible = "generic-ehci";reg = <0x9890000 0x100>;status = "okay";- };
+};
+&uart0 {
- clock = <75000000>;
- status = "okay";
+};
These are NOT U-Boot specific properties, they should be in the generic board dts file.
why did you ask me to remove them from the generic board dts file?
Lets wait for Alex to chime in on the status of getting the dts file / etc merged into Linux before doing v5. Thanks!
sure, no pb. thanks for the quick responses :)