Re: [U-Boot-Users] [PATCH] mips: Call 'nand_init()' in genericboard initialization when CONFIG_CMD_NAND is set

On Sat, 2008-05-17 at 01:26 +0900, Shinya Kuribayashi wrote:

Jason McMullan wrote:

...

+#include <nand.h>

This will break build. According to the blackfin, we can't even include <nand.h> if it's not configured.

That is, of course, why I originally just had 'extern int nand_init(void)' instead of the #include.

So, should I send in another patch with #ifdef CONFIG_CMD_NAND around the #include?

That seems messy, as including any common include nand.h shouldn't break the build regardless of the state of the CONFIG_CMD_* defines.

But that's just my opinion.

Jason McMullan MTS SW System Firmware

NetApp 724.741.5011 Fax 724.741.5166 Direct 412.656.3519 Mobile jason.mcmullan@netapp.com www.netapp.com