Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

On 01/04/2011 09:27 AM, Jason Liu wrote:

This patch add the MX53 boot image support.

This patch has been tested on Freescale MX53EVK board and MX51EVK board.

Signed-off-by: Jason Liu r64343@freescale.com

---

Changes for v2:

• Address the following comments from Stefano,
  • Get rid of #ifdef in the imximage.h and .c file and use the runtime check for imximage version
  • Document the IMXIMAGE_VERSION definiton in doc/README.imximage
  • Move mx53evk/config.mk and mx53evk/imximage.cfg to MX53EVK board support patch.

Changes for v3:

• Address the following comments from Stefano,
• Not change the mx51evk file. The code should take VERSION=1 as default, and we do not need to change the actual boards.
• add a note in the documentation and raise an error in code if the VERSION command is read after any other suitable commands.
• Change command IMXIMAGE_VERSION simply to IMAGE_VERSION
• Need recognize the version directly from its structure and not storing the version into the header when do header verify and print.
• Use function pointer to simpliy the code when the version of header is recognized

---

doc/README.imximage | 12 ++- tools/imximage.c | 421 ++++++++++++++++++++++++++++++++++++++++----------- tools/imximage.h | 110 +++++++++++--- 3 files changed, 433 insertions(+), 110 deletions(-)

Applied to u-boot-imx, thanks.

Best regards, Stefano Babic